Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Blank screen after requesting transcript #26385

Merged
merged 8 commits into from
Aug 22, 2022
Merged

[FIX] Blank screen after requesting transcript #26385

merged 8 commits into from
Aug 22, 2022

Conversation

MartinSchoeler
Copy link
Contributor

No description provided.

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 27, 2022 17:43
KevLehman
KevLehman previously approved these changes Jul 29, 2022
View reviewed changes
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2022
ggazzo
ggazzo requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to cover this case with some test?

@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 16, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 16, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 19, 2022
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner August 19, 2022 21:24
@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited
Loading

Codecov Report

Merging #26385 (dfa35fa) into develop (6e3306b) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head dfa35fa differs from pull request most recent head bfabf35. Consider uploading reports for the commit bfabf35 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26385      +/-   ##
===========================================
- Coverage    38.71%   38.59%   -0.12%     
===========================================
  Files          751      751              
  Lines        18670    18670              
  Branches      1453     1453              
===========================================
- Hits          7228     7206      -22     
- Misses       11225    11244      +19     
- Partials       217      220       +3
Flag Coverage Δ
e2e 38.59% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 71254af into develop Aug 22, 2022
@kodiakhq kodiakhq bot deleted the fix-blank-screen-transcript branch August 22, 2022 15:19
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@MartinSchoeler
[FIX] Blank screen after requesting transcript (#26385)
46fbeb0
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman left review comments

Assignees
No one assigned
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@MartinSchoeler @ggazzo @aleksandernsilva @KevLehman @alvaropmello @casalsgh @Harmeet221